DYN-8996 - Alert Users with Toast Notification for Double Click on Port#16289
Merged
johnpierson merged 13 commits intoDynamoDS:masterfrom Jun 12, 2025
Merged
DYN-8996 - Alert Users with Toast Notification for Double Click on Port#16289johnpierson merged 13 commits intoDynamoDS:masterfrom
johnpierson merged 13 commits intoDynamoDS:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8996
- alert user that the node autocomplete feature is now accessible under sparkle
johnpierson
force-pushed
the
dyn8996_toastForDoubleClick
branch
from
8386640 to
82a3408
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a toast notification when a user double-clicks a port to inform them to use the sparkle icon for Node Autocomplete.
- Detects double-click in
PortViewModel.Connect, shows a real-time info toast, and automatically closes it after 4 seconds. - Enables passing mouse event args into the connect command in both
OutPorts.xaml.csandInPorts.xaml.cs. - Introduces the resource string
ToastFileNodeAutoCompleteDoubleClickand cleans up duplicate entries in.resxfiles.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| PortViewModel.cs | Added double-click handling, toast display, and timer to close it. |
| OutPorts.xaml.cs & InPorts.xaml.cs | Set PassEventArgsToCommand = true for left-button triggers. |
| PortCommands.cs | Added (but did not use) nodeAutoCompleteToast field. |
| Resources.resx & Resources.en-US.resx | Added toast message resource and removed duplicates. |
| Dynamo.All.sln.DotSettings | Tweaked ReSharper naming rules configuration. |
Files not reviewed (1)
- src/DynamoCore/Properties/Resources.Designer.cs: Language not supported
Comments suppressed due to low confidence (2)
src/DynamoCoreWpf/ViewModels/Core/PortViewModel.cs:536
- [nitpick] Currently HandlePortClicked is always invoked before checking for a double click. If the goal is to only show the toast on double click (and not initiate a connection), consider returning early when
evArgs.ClickCount >= 2to prevent unintended connection logic.
workspaceViewModel.HandlePortClicked(this);
src/DynamoCoreWpf/ViewModels/Core/PortViewModel.cs:552
- The new double-click toast behavior should have unit or integration tests to verify the toast window appears and closes after the expected interval.
private void HandleDoubleClick()
Contributor
|
If I'm not mistaken in the past we used the information bubble of the node for these sort of things. And the bubble stays open until it is closed without timing. General notification system is more for the the general stuff. |
BogdanZavu
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds a toast notification when a user double-clicks a port to inform them to use the sparkle icon for Node Autocomplete.
Detects double-click in PortViewModel.Connect, shows a real-time info toast, and automatically closes it after 4 seconds.
Enables passing mouse event args into the connect command in both OutPorts.xaml.cs and InPorts.xaml.cs.
Introduces the resource string ToastFileNodeAutoCompleteDoubleClick and cleans up duplicate entries in .resx files.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
@DynamoDS/synapse
FYIs
@Jingyi-Wen