DYN-8995 - Add preferences view toggle for DNA menu#16284
Merged
johnpierson merged 9 commits intoDynamoDS:masterfrom Jun 11, 2025
Merged
DYN-8995 - Add preferences view toggle for DNA menu#16284johnpierson merged 9 commits intoDynamoDS:masterfrom
johnpierson merged 9 commits intoDynamoDS:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a toggle for the new Node Autocomplete Flyout in the preferences menu and updates the underlying view models and configuration settings accordingly.
- Added a new ToggleButton in the PreferencesView for enabling/disabling the new Node Autocomplete Flyout.
- Introduced a new binding property (NodeAutocompleteNewFlyoutIsChecked) in the PreferencesViewModel and corresponding configuration in PreferenceSettings.
- Updated logic in PortViewModel and PortCommands to use the new flyout flag and removed obsolete code pathways.
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml | Added a new RowDefinition and StackPanel with a new ToggleButton for the flyout feature. |
| src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs | Added a new property to bind the new toggle state from the preference settings. |
| src/DynamoCoreWpf/ViewModels/Core/PortViewModel.cs | Integrated conditional logic based on the new flyout flag and removed the obsolete AutoCompleteCluster method block. |
| src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs | Added the IsNewDNAFlyoutEnabled property to facilitate controlling the new flyout behavior. |
| src/DynamoCoreWpf/PublicAPI.Unshipped.txt, src/DynamoCore/PublicAPI.Unshipped.txt | Updated public API documentation to expose the new preference settings. |
| src/DynamoCoreWpf/Commands/PortCommands.cs | Changed the DelegateCommand logic to remove the dependency on the DNAClusterPlacementEnabled flag. |
| src/DynamoCore/Configuration/PreferenceSettings.cs | Added a new preference setting with a default value for the new flyout feature. |
Files not reviewed (1)
- src/DynamoCoreWpf/Properties/Resources.Designer.cs: Language not supported
Comments suppressed due to low confidence (3)
src/DynamoCoreWpf/Commands/PortCommands.cs:35
- The removal of the condition based on DNAClusterPlacementEnabled may impact behavior; please verify that this change is intended and that the new logic conforms with feature requirements.
autoCompleteCommand ??= new DelegateCommand(AutoComplete, CanAutoComplete);
src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs:1134
- [nitpick] Consider aligning naming conventions between 'NodeAutocompleteNewFlyoutIsChecked' and 'IsNewDNAFlyoutEnabled' for consistency across view models, if they represent the same feature state.
public bool NodeAutocompleteNewFlyoutIsChecked
src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml:945
- [nitpick] The margin for the new StackPanel has been updated to '0,12,0,0'; please confirm that this spacing aligns with the intended design across similar UI elements.
<StackPanel Orientation="Horizontal" Margin="0,12,0,0" Grid.Row="1">
johnpierson
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8995
Contributor
|
Pref options look nice and clear! |
Member
Author
|
hmm, this search? It seems to be loading while I debug |
Contributor
Well.. I made a rebuild and I'm not reproducing the issue anymore so I think we're good to go! |
BogdanZavu
approved these changes
Jun 10, 2025
Update test settings file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR introduces a toggle for the new Node Autocomplete Flyout in the preferences menu and updates the underlying view models and configuration settings accordingly.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/synapse @Jingyi-Wen
FYIs
@Amoursol @QilongTang