DYN-8535 : improvements to existing dna#16232
Merged
BogdanZavu merged 3 commits intoDynamoDS:masterfrom May 28, 2025
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8535
8 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the node auto complete functionality by reusing the auto complete window, adding a timeout to the ML service request, and refining event subscription management for multiple workspaces.
- Removed redundant check in WorkspaceView before showing the auto complete control and replaced window instantiation with a reusable static call.
- Updated ML service request configuration with a specified timeout and refactored event subscription handling in both the ViewModel and Control.
- Introduced a static instance management approach to reuse the NodeAutoCompleteSearchControl window across workspaces.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/DynamoCoreWpf/Views/Core/WorkspaceView.xaml.cs | Updates to use the reusable auto complete search control window. |
| src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs | Added timeout configuration for ML service request and adjusted event subscription management. |
| src/DynamoCoreWpf/Controls/NodeAutoCompleteSearchControl.xaml.cs | Refactored auto complete control to utilize a single static instance with improved event subscription/unsubscription logic. |
Files not reviewed (1)
- src/DynamoCoreWpf/Controls/NodeAutoCompleteSearchControl.xaml: Language not supported
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
…Model.cs Co-authored-by: Copilot <[email protected]>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve existing node auto complete. We can also integrate these improvements into the new flyout as we see fit.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
@DynamoDS/synapse
FYI
@QilongTang