[DYN-8655] Custom selections node loses contents on Copy#16202
Merged
jasonstratton merged 2 commits intoDynamoDS:masterfrom May 12, 2025
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8655
Contributor
|
Hi @ivaylo-matov For this quarter, you can @DynamoDS/eidos in the reviewer section and assign the review to @jasonstratton. He should be able to help most of the reviews. |
Contributor
Author
|
Thank you, @QilongTang . Will do. |
jasonstratton
approved these changes
May 12, 2025
Contributor
jasonstratton
left a comment
jasonstratton
left a comment
There was a problem hiding this comment.
This looks pretty straightforward to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR aims to address DYN-8655.
I've added custom serialization and deserialization logic to
CustomSelectionto carry over both the dropdown items and the selected index during copy/paste. Now, both the content and the selected item are carried over when the node is copied.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
The Custom Selection node now carries over both the content and the selected item when copied.
Reviewers
@DynamoDS/eidos
@jasonstratton
FYIs
@achintyabhat
@dnenov
@Amoursol