DYN-8308: Fix temporary connector and Node memory leak#16198
Merged
zeusongit merged 1 commit intoDynamoDS:masterfrom May 13, 2025
Merged
DYN-8308: Fix temporary connector and Node memory leak#16198zeusongit merged 1 commit intoDynamoDS:masterfrom
zeusongit merged 1 commit intoDynamoDS:masterfrom
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8308
reddyashish
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Based on #15832
It was identified that when working with connectors, the temporary connectors (dotted wires) were not properly disposed, the PR disposes them properly when the wire connection is made.
Also, added a few more unsubscription related to nodes.
Results:
Tested twice with VS Memory Profiler.
Action: Opened Mars graph and closed twice in the same session.
After (Left) : Before (Right)

NodeViewModel (Inclusive of all child elements size):
Before: ~150 MB
After: ~10MB
~93% drop
(The drop was due to node leak fix, as no interaction was done with wires when testing)
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/eidos