DYN-8802: Use Panel based port size calculation only for CodeBlockNodes#16184
Merged
zeusongit merged 1 commit intoDynamoDS:masterfrom May 5, 2025
Merged
DYN-8802: Use Panel based port size calculation only for CodeBlockNodes#16184zeusongit merged 1 commit intoDynamoDS:masterfrom
zeusongit merged 1 commit intoDynamoDS:masterfrom
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8802
sm6srw
approved these changes
May 5, 2025
aparajit-pratap
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
It was identified that Measure/Arrange override methods in InOutPortPanel consumed a lot of cycles when loading a graph, it was noted that the custom solution was implemented specifically for CBN nodes to align incremental ports (PR).
It was being triggered recursively for each port on each node irrespective of it's type. As a resolution in this PR the target style is made conditional, so we will use the InOutPortPanel based style only for CodeBlock nodes.
Results:
~83000 ms -> ~70000 ms (~16% faster)
(After left - Before right)

Profiled with 1024PointsByCoordinate nodes graph and tested with Manekin as well
(Still testing with more nodes)
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Use Panel based port size calculation only for CodeBlockNodes
Reviewers