DYN-8749 Handle crash when closing splash screen after DynamoView load#16175
Merged
zeusongit merged 1 commit intoDynamoDS:masterfrom May 5, 2025
Merged
DYN-8749 Handle crash when closing splash screen after DynamoView load#16175zeusongit merged 1 commit intoDynamoDS:masterfrom
zeusongit merged 1 commit intoDynamoDS:masterfrom
Conversation
zeusongit
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8749
reddyashish
approved these changes
Apr 29, 2025
| await webView.CoreWebView2.ExecuteScriptAsync($"window.setLoadingDone()"); | ||
| await webView.CoreWebView2.ExecuteScriptAsync($"window.setTotalLoadingTime(\"{Wpf.Properties.Resources.SplashScreenTotalLoadingTimeLabel} {totalLoadingTime}ms\")"); | ||
| SetSignInEnable(enableSignInButton); | ||
| Console.WriteLine(ex.Message); |
Contributor
There was a problem hiding this comment.
Does Dynamo continue to load safely if the exception thrown by prematurely closing the splash screen is caught here?
Contributor
Author
There was a problem hiding this comment.
Yes..well I mean crash happens when closing Splash screen, just before Dynamo is loaded, so by handling it here it won't crash Revit, and Dynamo will continue to shutdown.
QilongTang
pushed a commit
that referenced
this pull request
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In some cases, when splash screen is closed right before it is done with loading Dynamo View (last step), it crashes. It is rare to reproduce since the window is pretty small, still I was able to reproduce this once or twice.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Handle crash when closing splash screen after DynamoView load
Reviewers