DYN-8095: Handle crash by using FirstOrDefault() instead of First()#15958
Merged
zeusongit merged 3 commits intoDynamoDS:masterfrom Mar 21, 2025
Merged
DYN-8095: Handle crash by using FirstOrDefault() instead of First()#15958zeusongit merged 3 commits intoDynamoDS:masterfrom
zeusongit merged 3 commits intoDynamoDS:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8095
reddyashish
approved these changes
Mar 20, 2025
Contributor
aparajit-pratap
left a comment
aparajit-pratap
left a comment
There was a problem hiding this comment.
Can we add a test?
Contributor
Author
We already had some test for this, I added to it. |
aparajit-pratap
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The crash was thrown with
ThrowNoMatchExceptionfrom the linq statement.First()was used at multiple places, which is now replaced withFirstOrDefault()which instead of throwing an exception will return the default value.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Handle crash by using FirstOrDefault() instead of First()
Reviewers
@DynamoDS/dynamo