Skip to content

DYN-8457: Fix when inserting groups from Help doc should have correct name #2#15939

Merged
zeusongit merged 4 commits intoDynamoDS:masterfrom
zeusongit:DYN-8457
Mar 18, 2025
Merged

DYN-8457: Fix when inserting groups from Help doc should have correct name #2#15939
zeusongit merged 4 commits intoDynamoDS:masterfrom
zeusongit:DYN-8457

Conversation

@zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Mar 17, 2025

Purpose

In the previous implementation (#15910), we fixed the regressed behavior to fix group name of the inserted graphs from help docs.
But since most graphs are name after a hashed value, the group names did not make much sense. Therefore, updating the inserted graph group name to be the node name for which the help doc was requested.

Before:
InvalidGroupName

After:
Screenshot 2025-03-17 at 5 24 17 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Inserted graph group name to be the node name for which the help doc was requested

Reviewers

@DynamoDS/dynamo

@zeusongit zeusongit requested review from reddyashish and sm6srw March 17, 2025 21:26
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeusongit zeusongit merged commit abab223 into DynamoDS:master Mar 18, 2025
26 of 27 checks passed
@zeusongit zeusongit added this to the 3.5 milestone Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants