[DYN-7719] Shortcut buttons blink on periodic mode#15919
Merged
reddyashish merged 1 commit intoDynamoDS:masterfrom Mar 18, 2025
Merged
[DYN-7719] Shortcut buttons blink on periodic mode#15919reddyashish merged 1 commit intoDynamoDS:masterfrom
reddyashish merged 1 commit intoDynamoDS:masterfrom
Conversation
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7719
ivaylo-matov
changed the title
QilongTang
approved these changes
Mar 17, 2025
reddyashish
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses DYN-7719, where the New and Open shortcut buttons blink during graph execution in Periodic Run mode.
The flickering was caused by RunSettingsViewModel.NotifyOfGraphRunChanged, which was toggling the IsEnabled state of UI elements on every execution cycle. To resolve this, UI updates are suppressed when DynamoModel is in Periodic Run mode, preventing unnecessary changes to the shortcut buttons.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Open and New shortcut buttons will no longer blink in periodic run mode.
Reviewers
@QilongTang
@reddyashish
FYIs
@dnenov
@achintyabhat