[DYN-6758] [DYN-6759] Updating inconsistencies in Core.Math.dyn sample file. #15893
Merged
QilongTang merged 1 commit intoDynamoDS:masterfrom Mar 18, 2025
Conversation
… the one in Library Updating CORE: Inconsistency between name of option given in the note (Math sample) and the one in the menu
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6758
Contributor
|
@avidit |
QilongTang
reviewed
Mar 5, 2025
| "Zoom": 0.28542192141810496 | ||
| "X": 51.34875002226386, | ||
| "Y": 800.7886260085731, | ||
| "Zoom": 0.19068736946261172 |
Contributor
There was a problem hiding this comment.
I wonder if it's the change of view port making the smoke tests fail, @EdwardChaplinArchilizer maybe revert the changes here. FYI: @reddyashish @zeusongit
Contributor
Contributor
I am getting sporadic build failures. I am trying to find the cause. I will rerun the job just in case. |
QilongTang
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR address DYN-6758 & DYN-6759.
It addresses Inconsistency between menu name given in the description and the one in Library (DYN-6758)
Before:
After:
It also addresses Inconsistency between name of option given in the note (Math sample) and the one in the menu (DYN-6759)
Before:
After:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Updating the Core_Math.dyn sample file. Specifically updating Unclear note of "Code Block" node in Strings sample and Unclear note of "Code Block" node in Code Blocks sample.
Reviewers
@dnenov
@achintyabhat
@QilongTang
Informed
@Amoursol