[DYN-8072] Opening file from home tab should check is workspace has unsaved changes#15870
Merged
reddyashish merged 3 commits intoDynamoDS:masterfrom Mar 4, 2025
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8072
QilongTang
reviewed
Feb 28, 2025
zeusongit
approved these changes
Mar 3, 2025
Contributor
|
@ivaylo-matov Can you address the conflicts? Thanks. |
…r-unsaved-changes-when-open-file-from-home-tab
Contributor
Author
done! Thanks! |
reddyashish
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses DYN-8072 where users were not always prompted to save changes when opening a new graph from the Recent Files section.
Changes Implemented:
AskUserToSaveWorkspaceOrCancelis called when opening a new graph.HasUnsavedChangeshandling.Now, after the user confirms saving or discarding changes,
workspace.HasUnsavedChangesis properly set.Expected Behavior After the Fix:
HasUnsavedChangesis correctly updated.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Changes Implemented:
Now, after the user confirms saving or discarding changes, workspace.HasUnsavedChanges is properly set.
Expected Behavior After the Fix:
Reviewers
@QilongTang
@reddyashish
FYIs
@dnenov
@achintyabhat