Skip to content

DYN-8275 HTML Localization Controls#15867

Merged
QilongTang merged 4 commits intoDynamoDS:master_clfrom
RobertGlobant20:DYN-8275-HTML-Localization-Controls
Mar 4, 2025
Merged

DYN-8275 HTML Localization Controls#15867
QilongTang merged 4 commits intoDynamoDS:master_clfrom
RobertGlobant20:DYN-8275-HTML-Localization-Controls

Conversation

@RobertGlobant20
Copy link
Contributor

@RobertGlobant20 RobertGlobant20 commented Feb 27, 2025

Purpose

Source Level Localization of html files located in the Controls folder (html for FileTrustWarning and NodeAutocomplete)

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Source Level Localization of html files located in the Controls folder (html for FileTrustWarning and NodeAutocomplete)

Reviewers

@QilongTang @reddyashish

FYIs

@ZbynekHanak-RWS

@RobertGlobant20
DYN-8275 HTML Localization Controls
f186875 
I've added the html files for each language as embedded resources in the DynamoCoreWpf project.
I've added the Copy Tasks for copying html files from Dynamo\doc\distrib\html\en-US\Controls to Dynamo\src\DynamoCoreWpf\Controls\Docs.
@RobertGlobant20
DYN-8275 HTML Localization Controls
e879061 
Updating Copy Task due that was copying to a wrong location
@RobertGlobant20
Merge branch 'master_cl' into DYN-8275-HTML-Localization-Controls
96f086a
@RobertGlobant20
DYN-8275 HTML Localization Controls
84a87fb 
Updating the DSCoreNodes.xml due that a new node was added recently
github-actions[bot]
github-actions bot reviewed Feb 27, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8275

@RobertGlobant20
Copy link
Contributor Author

RobertGlobant20 commented Mar 3, 2025

@QilongTang @reddyashish
any comment about this changes?

@reddyashish
Copy link
Collaborator

reddyashish commented Mar 3, 2025

Looks good to me. @QilongTang Any comments?

@QilongTang
Copy link
Contributor

QilongTang commented Mar 3, 2025

@RobertGlobant20 Do we need localized html in repo path like Controls\Docs\cs-CZ? I thought they will be only at doc/distrib/html/cs-CZ/Controls?

@RobertGlobant20
Copy link
Contributor Author

RobertGlobant20 commented Mar 3, 2025

@RobertGlobant20 Do we need localized html in repo path like Controls\Docs\cs-CZ? I thought they will be only at doc/distrib/html/cs-CZ/Controls?

I think we need the files right now in Controls\Docs\cs-CZ just for compiling reasons, later (when loc team merge the html for all languages) won't be important to have them due that we have instructions that will copy the files from doc/distrib/html/cs-CZ/Controls to Controls\Docs\cs-CZ, the only important part is that we need the files as embedded resources in the csproj.
I included those files due that otherwise BuildDynamo check will fail due that we don't have all the html files in doc/distrib/html/cs-CZ/Controls right now and the compiler will detect that we are missing embedded resources.

@QilongTang
Copy link
Contributor

QilongTang commented Mar 3, 2025

@RobertGlobant20 Do we need localized html in repo path like Controls\Docs\cs-CZ? I thought they will be only at doc/distrib/html/cs-CZ/Controls?

I think we need the files right now in Controls\Docs\cs-CZ just for compiling reasons, later (when loc team merge the html for all languages) won't be important to have them due that we have instructions that will copy the files from doc/distrib/html/cs-CZ/Controls to Controls\Docs\cs-CZ, the only important part is that we need the files as embedded resources in the csproj. I included those files due that otherwise BuildDynamo check will fail due that we don't have all the html files in doc/distrib/html/cs-CZ/Controls right now and the compiler will detect that we are missing embedded resources.

Gotcha, thanks!

@RobertGlobant20 RobertGlobant20 mentioned this pull request Mar 3, 2025
Merged
9 tasks
@QilongTang QilongTang merged commit 387a5c7 into DynamoDS:master_cl Mar 4, 2025
24 checks passed
@zeusongit zeusongit added this to the 3.5 milestone Mar 19, 2025
RobertGlobant20 added a commit to RobertGlobant20/Dynamo that referenced this pull request Mar 24, 2025
@RobertGlobant20
DYN-8275 HTML Localization Controls (DynamoDS#15867)
65cb42d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QilongTang QilongTang QilongTang approved these changes

@reddyashish reddyashish Awaiting requested review from reddyashish

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5

Development

Successfully merging this pull request may close these issues.

4 participants

@RobertGlobant20 @reddyashish @QilongTang @zeusongit