Skip to content

DYN-7368: CER crash - catch exception from dynamomessagebox#15850

Merged
zeusongit merged 2 commits intoDynamoDS:masterfrom
aparajit-pratap:dyn-7368
Mar 3, 2025
Merged

DYN-7368: CER crash - catch exception from dynamomessagebox#15850
zeusongit merged 2 commits intoDynamoDS:masterfrom
aparajit-pratap:dyn-7368

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Feb 24, 2025

Purpose

DYN-7368: CER crash - catch exception from dynamomessagebox

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Catch unexpected exceptions thrown from DynamoMessageBox while saving backup files.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

github-actions[bot]
github-actions bot reviewed Feb 24, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7368

zeusongit
zeusongit reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@zeusongit zeusongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way we can log the exception here?

@aparajit-pratap
Copy link
Contributor Author

aparajit-pratap commented Feb 25, 2025 •
edited
Loading

@avidit can you tell me how I can investigate the UI smoke test failures? I see that these are test complete tests. Any idea why these could be failing from this PR?

Hmm, it looks like these tests are failing with other PRs too.

@avidit
Copy link
Contributor

avidit commented Feb 25, 2025

@avidit can you tell me how I can investigate the UI smoke test failures? I see that these are test complete tests. Any idea why these could be failing from this PR?

Hmm, it looks like these tests are failing with other PRs too.

We are not maintaining these tests anymore. I am working on replacing these with AGT tests. We can ignore these failures for now.

reddyashish
reddyashish approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@reddyashish reddyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeusongit zeusongit added this to the 3.5 milestone Mar 3, 2025
@zeusongit zeusongit merged commit 0f213c8 into DynamoDS:master Mar 3, 2025
22 of 23 checks passed
@aparajit-pratap aparajit-pratap deleted the dyn-7368 branch March 3, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@zeusongit zeusongit zeusongit approved these changes

@reddyashish reddyashish reddyashish approved these changes

@sm6srw sm6srw Awaiting requested review from sm6srw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5

Development

Successfully merging this pull request may close these issues.

4 participants

@aparajit-pratap @avidit @zeusongit @reddyashish