DYN-8353: Allow tests to run against ASM231#15848
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8353
There was a problem hiding this comment.
Looks like I lost this file. Need to check.
There was a problem hiding this comment.
This file was not referenced anywhere as far as I can tell.
There was a problem hiding this comment.
Linux is back. I need to clean up this file.
|
Job running against ASM231 succeeded here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/dahlj%252Ftesting_master/61/ |
|
This is now ready for review. |
zeusongit
left a comment
zeusongit
left a comment
There was a problem hiding this comment.
LGTM, although does this mean that we will have to split the tests again as we reach a certain number of tests in a single project?
I think this is related to WPF in this case. We do have issues with resource leaks that needs to be fixed at some point. But in general, I do think it is better to have a larger number of but smaller test assemblies so we should not be afraid to create new ones. |
2 participants
Purpose
This pull request does:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of