DYN-: DYN 8294 Fix crash when placing node after undo operation using DNA#15842
Merged
zeusongit merged 1 commit intoDynamoDS:masterfrom Feb 19, 2025
Merged
DYN-: DYN 8294 Fix crash when placing node after undo operation using DNA#15842zeusongit merged 1 commit intoDynamoDS:masterfrom
zeusongit merged 1 commit intoDynamoDS:masterfrom
Conversation
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8294
QilongTang
approved these changes
Feb 19, 2025
Contributor
|
I guess these interactions with DNA is not unit testable? Is there a plan to add AGT test? |
Contributor
Author
This specific example was an edge case, which only reproduced if a user did Undo operation, while not unit testable, it should be doable with AGT. I will add a task for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR handles the exception thrown after a user tries to place a node following an undo operation using NodeAutocomplete feature, the cause was a null object reference.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/dynamo