don't execute the setup method for NodeManipulatorExtensionTests tests twice#15768
don't execute the setup method for NodeManipulatorExtensionTests tests twice#15768mjkkirschner wants to merge 2 commits intoDynamoDS:masterfrom
Conversation
mjkkirschner
changed the title
| { | ||
| [SetUp] | ||
| public virtual void Start() | ||
| public override void Start() |
There was a problem hiding this comment.
nice!. DId you try to turn on the dispatrcher ops waiting after this change ?
There was a problem hiding this comment.
I did not, will give it a shot, were you able to repro the helix crash locally?
There was a problem hiding this comment.
on second thought, there's no reason for this method to exist if we're flushing the dispatcher.
Also, I think theres something weird with the way we increment the dispatcher ops when this flag is true...
There was a problem hiding this comment.
I did manage to reproduce the crash locally
…flushing the queue
| public void Exit() | ||
| { | ||
|
|
||
| Dispatcher.CurrentDispatcher.Hooks.OperationPosted -= Hooks_OperationPosted; |
There was a problem hiding this comment.
should we remove the handler only after the DoEventsLoop ?
I wonder if operations can still post other operations..
UI Smoke TestsTest: success. 11 passed, 0 failed. |
3 participants
Purpose
I noticed that because we were not overriding the start method and instead hiding it that nunit was calling both methods that were marked with
[setup]so we were basically starting dynamo twice. I have no idea if this will stabilize the intermittent failures we have been seeing but it can't hurt!locally, this change lowers the number of operations in the dispatcher queue from 131 to 28 when it moves on to the next test fixture.