[DYN-8026] Fix watch node which has corrupted size.#15755
Merged
reddyashish merged 2 commits intoDynamoDS:masterfrom Jan 14, 2025
Merged
[DYN-8026] Fix watch node which has corrupted size.#15755reddyashish merged 2 commits intoDynamoDS:masterfrom
reddyashish merged 2 commits intoDynamoDS:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8026
UI Smoke TestsTest: success. 11 passed, 0 failed. |
Member
|
nice, thanks for fixing this @reddyashish - can you add a test for it? |
mjkkirschner
approved these changes
Jan 14, 2025
Collaborator
Author
|
The failing test in the job is a flaky unrelated one: SplashScreen_MultipleCloseMessages. Passes locally. |
Contributor
|
Thanks @reddyashish let's demo it next time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Task: https://jira.autodesk.com/browse/DYN-8026
Before:
Fixes the case where watch node has a wrong size serialized in the graph.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
[DYN-8026] Fix watch node which has corrupted size.
Reviewers
@QilongTang @mjkkirschner