Fix Geometry.IsAlmostEqualTo Sample#15738
Merged
QilongTang merged 3 commits intoDynamoDS:masterfrom Jan 10, 2025
johnpierson:fix_geometryIsAlmostEqualSample
Merged
Fix Geometry.IsAlmostEqualTo Sample#15738QilongTang merged 3 commits intoDynamoDS:masterfrom johnpierson:fix_geometryIsAlmostEqualSample
QilongTang merged 3 commits intoDynamoDS:masterfrom
johnpierson:fix_geometryIsAlmostEqualSample
Conversation
Previously the sample's description was a verbatim copy of Vector.IsAlmostEqual to. FYI @Amoursol
UI Smoke TestsTest: success. 11 passed, 0 failed. |
QilongTang
approved these changes
Jan 7, 2025
Contributor
|
Nice fix. Please hold on merging this PR since Morpheus team is updating localization pipeline and process, will come back to this |
QilongTang
added
DNM
Contributor
|
@johnpierson Now that node help localization pipeline changes are done, would you update this PR to aim the file under |
Member
Author
|
Will do!
…On Thu, Jan 9, 2025 at 3:56 PM Aaron (Qilong) ***@***.***> wrote:
@johnpierson <https://github.com/johnpierson> Now that node help
localization pipeline changes are done, would you update this PR to aim the
file under en-US folder instead of root folder?
—
Reply to this email directly, view it on GitHub
<#15738 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADYD5VHLXN5BJJPJMYBUEVL2J35DVAVCNFSM6AAAAABUJEYSM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBRGQYDGNZRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
QilongTang
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
To fix the Geometry.IsAlmostEqualTo sample. The description was a copy of Vector.IsAlmostEqualTo
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
@achintyabhat
FYIs
@Amoursol