[DYN-7841] Placement of wire for input ports in off when the group is collapsed#15697
Merged
reddyashish merged 1 commit intoDynamoDS:masterfrom Dec 4, 2024
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7841
reddyashish
approved these changes
Dec 3, 2024
UI Smoke TestsTest: success. 11 passed, 0 failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PR aims to address DYN-7841 which reported a misalignment between the centers of inports and the connector ends when a group is collapsed.
The issue was caused by a mismatch between
PortModel.Height(34) andGrid.Height(35) in the related views. This inconsistency was resolved by setting both values to 34.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixed an issue where inports were misaligned with connector ends when a group was collapsed by standardizing port dimensions.
Reviewers
@reddyashish
@QilongTang
FYIs
@dnenov