[DYN-7840] Placement of UI pop up for input nodes in collapsed group mode is not accurate#15696
Merged
reddyashish merged 1 commit intoDynamoDS:masterfrom Dec 4, 2024
ivaylo-matov:DYN-7840-Placement-of-UI-pop-up-for-input-nodes-in-collapsed-group-mode-is-not-accurate
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7840
UI Smoke TestsTest: success. 11 passed, 0 failed. |
reddyashish
reviewed
Dec 3, 2024
Collaborator
|
Looks good, Thanks @ivaylo-matov. Just one comment on reusing utility methods. Dynamo.Tests.PythonEditTests fixture is failing. Doesn't look related. |
reddyashish
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PR aims to address DYN-7840 where the placement of the UI pop for input ports are off when the group is collapsed.
The code now uses the proxyPorts as
PlacementTargetand uses different placement method for them.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixed placement of Context menu popup for nodes in collapsed groups.
Reviewers
@reddyashish
@QilongTang
FYIs
@dnenov