DYN-7945 pin home button when reducing library size#15692
Merged
QilongTang merged 4 commits intoDynamoDS:masterfrom Dec 2, 2024
Merged
DYN-7945 pin home button when reducing library size#15692QilongTang merged 4 commits intoDynamoDS:masterfrom
QilongTang merged 4 commits intoDynamoDS:masterfrom
Conversation
- pin the home button similar to the tab items
UI Smoke TestsTest: success. 11 passed, 0 failed. |
reddyashish
reviewed
Dec 2, 2024
|
|
||
| private void PinHomeButton() | ||
| { | ||
| const int FirstTabItemMinimumLeftMarginOffset = 230; |
Collaborator
There was a problem hiding this comment.
These constants are defined in UpdateWorkspaceTabSizes also, can you put them in the class and remove duplicates.
Collaborator
Author
There was a problem hiding this comment.
I was hesitant to touch the DynamoView class further, but thought about it too. That's now done, but I opted to keep the class variables close to the first place where they are used to reduce clutter.
Collaborator
|
LGTM with one comment. |
QilongTang
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7945
QilongTang
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
We calculate and limit the leftmost position of the tabs in the Dynamo screen. After recently implementing a Home button, this PR ensures we follow a similar principle for pinning the Home button consistent with the Tab Items.
UI Changes
The
Homebutton will now only travel as far to the left as required to not overlap the button row.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of