DYN-7889: Improve parsing and compatibility of user-provided dynamo/host versions#15682
Merged
QilongTang merged 1 commit intoDynamoDS:masterfrom Nov 22, 2024
Merged
Conversation
…lity matrix versions - there was a mismatch between fully-formed "2.1.9.2150" Dynamo/Host versions, and the incoming build/major/minor versions
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7889
dnenov
changed the title
UI Smoke TestsTest: success. 11 passed, 0 failed. |
zeusongit
approved these changes
Nov 22, 2024
reddyashish
approved these changes
Nov 22, 2024
QilongTang
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This is a hot-fix to address the discrepancy between internal
dynamo/hostversions (which are fully formed, eg. "2.1.19.2145") and the compatibility versions provided by users (partly formed, eg. "2.1.19" or even "2").singleversionsmin/maxversionsDeclarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@zeusongit
@QilongTang
FYIs
@jnealb