DYN-7790 fix package tour terms of use step#15681
Merged
QilongTang merged 1 commit intoDynamoDS:masterfrom Nov 21, 2024
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7790
UI Smoke TestsTest: success. 11 passed, 0 failed. |
RobertGlobant20
approved these changes
Nov 21, 2024
Contributor
RobertGlobant20
left a comment
RobertGlobant20
left a comment
There was a problem hiding this comment.
LGTM, could you add a GIF of the packages tour when the TermsOfUse has not been accepted yet?
Contributor
Author
Added both flows (with and without previously accepted TOU) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Dynamo.Wpf.UI.GuidedTour.GuidesValidationMethods.ExecuteTermsOfServiceFlowsearches for the TermsOfUse window as owned byDynamoViewinGuideUtilities.FindWindowOwned(stepInfo.HostPopupInfo.WindowName, stepInfo.MainWindow as Window)but can't find it due to it being owned by no one (null). This PR thus allows the user to complete the packages tour. Allows for dependent Package Tour testing ticket DYN-7664 to be completed.Process without previously accepted TOU:
Process with previously accepted TOU:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Solve DYN-7790 to fix Packages interactive tour
Reviewers
@RobertGlobant20
@QilongTang
FYIs
@avidit