Skip to content

DYN-7736 Update Splash Screen#15616

Merged
QilongTang merged 4 commits intomasterfrom
UpdateSplashScreen
Nov 8, 2024
Merged

DYN-7736 Update Splash Screen#15616
QilongTang merged 4 commits intomasterfrom
UpdateSplashScreen

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Nov 7, 2024 •
edited
Loading

Purpose

Update Splash Screen for GL 25 with reduced image size for the npm package. Also update the image used in Dynamo repo.

After:
image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Update Splash Screen for GL 25 with reduced image size

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@github-actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang
Copy link
Contributor Author

QilongTang commented Nov 7, 2024 •
edited
Loading

@zeusongit looks like the public action build passed but build under VPN could not grab the latest npm package, have you seen this before?

This looks like a timing issue for ADSK to map public npm registry, now has been resolved

@QilongTang QilongTang added this to the 3.4 milestone Nov 7, 2024
@QilongTang QilongTang changed the title Update Splash Screen DYN-7736 Update Splash Screen Nov 7, 2024
github-actions[bot]
github-actions bot reviewed Nov 7, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7736

@QilongTang QilongTang requested a review from zeusongit November 7, 2024 16:02
@QilongTang QilongTang mentioned this pull request Nov 7, 2024
Merged
@zeusongit
Copy link
Contributor

zeusongit commented Nov 7, 2024

Build failed as v26 was not available yet, Rebuild started here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16758/

@QilongTang
Copy link
Contributor Author

QilongTang commented Nov 8, 2024 •
edited
Loading

Thank you @zeusongit Also passed in https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16763/

@QilongTang QilongTang merged commit 7b33c30 into master Nov 8, 2024
@QilongTang QilongTang deleted the UpdateSplashScreen branch November 8, 2024 07:14
QilongTang added a commit that referenced this pull request Nov 8, 2024
@QilongTang
DYN-7736 Update Splash Screen (#15616)
6ddb1c4
@QilongTang QilongTang mentioned this pull request Nov 8, 2024
Merged
9 tasks
QilongTang added a commit that referenced this pull request Nov 8, 2024
@QilongTang @dnenov
[CherryPick] DYN-7736 Update Splash Screen (#15616) (#15622)
9466cda 
Co-authored-by: Deyan Nenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@zeusongit zeusongit zeusongit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

2 participants

@QilongTang @zeusongit