DYN-7523: new line handling fix#15585
Merged
reddyashish merged 1 commit intoDynamoDS:masterfrom Nov 5, 2024
Merged
Conversation
- now accepts return for new line in Description text box - xaml reformatted automatically
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7523
UI Smoke TestsTest: success. 11 passed, 0 failed. |
reddyashish
reviewed
Nov 4, 2024
| xmlns:d="http://schemas.microsoft.com/expression/blend/2008" | ||
| xmlns:local="clr-namespace:Dynamo.PackageManager.UI" | ||
| mc:Ignorable="d" |
Collaborator
There was a problem hiding this comment.
This file has lot of changes that are just moved to a different line. Are you using any setting and are these intended?
Collaborator
There was a problem hiding this comment.
Talked to deyan about this and should be fine.
reddyashish
approved these changes
Nov 5, 2024
reddyashish
pushed a commit
to reddyashish/Dynamo
that referenced
this pull request
Nov 5, 2024
(cherry picked from commit 40c02e7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix an issue where the 'Enter' key would not trigger a carriage return.
Changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
@QilongTang
FYIs