DYN-7337 Make TuneUp an Built-In package, part II#15536
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7337
QilongTang
changed the title
UI Smoke TestsTest: success. 11 passed, 0 failed. |
| <MakeDir Directories="$(OutputPath)\viewExtensions\" /> | ||
| <Copy SourceFiles="@(ExternTuneUpDll)" DestinationFolder="$(OutputPath)\Built-In Packages" /> | ||
| <Copy SourceFiles="@(ExternTuneUpManifest)" DestinationFolder="$(OutputPath)\viewExtensions" /> | ||
| <Copy SourceFiles="@(ExternTuneUpPkg)" DestinationFolder="$(OutputPath)\Built-In Packages\packages\TuneUp\%(RecursiveDir)" /> |
There was a problem hiding this comment.
Copy files recursively and keeping the folder structure
| Log(String.Format( | ||
| String.Format(Resources.InvalidPackageNoNodeLibrariesDefinedInPackageJson, | ||
| discoveredPkg.Name, discoveredPkg.RootDirectory))); | ||
| } |
There was a problem hiding this comment.
Remove the node library dll check because Built-In package moving forward may not always include nodes so this is no longer needed, even the logging
| AnyCPU/ | ||
| Debug/ | ||
| Release/ | ||
| originalBinaries/ |
There was a problem hiding this comment.
ignore dlls under built directory more precisely
|
Not sure if the two remaining tests about Node Autocomplete is related to this PR at all, re-running in https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16549/ |
| <PackageReference Include="CommandLineParser" Version="2.8.0" /> | ||
| <PackageReference Include="CsvHelper" Version="30.0.1" /> | ||
| <PackageReference Include="Greg" Version="3.0.1.4707" /> | ||
| <PackageReference Include="Greg" Version="3.0.2.6284" /> |
There was a problem hiding this comment.
Why are we changing the greg version only for this project?
There was a problem hiding this comment.
@reddyashish This project seems to be behind (not aligned with all the other project)
There was a problem hiding this comment.
Add this dll to the list of shipped binaries?
There was a problem hiding this comment.
This is a test dll generated runtime, I have removed it and updated gitignore
|
@reddyashish @zeusongit I updated to latest TuneUp, and all regressions are passing from previous run so this should be all good |
|
I dont think the error from the Build DynamoAll.sln is from this branch.. |
Interestingly, I was getting the same error |
One test failing, did it pass in another build? |
@zeusongit Yup, the reported failure is a sporadic one. The build errors is from master branch itself, most likely from #15439. I dont think we are supposed to merge that.. |
4 participants
Purpose
Before:
After:
Expected folder structure under DynamoCore:
Common Errors:
When user have both Built-in package and downloaded package exist
When user tries to download the same package while Built-In package exist
When user tries to download a newer version of the package while Built-In package exist
When user tries to download an older version of the package while Built-In package exist
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Make TuneUp an Built-In package and follow package folder structure, also improve Dynamo logging
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of