Purpose

Continuation of and older task that might not have been fully addressed the first time around - a link to the original PR can be found here: #14507

Context

Currently, only CustomFunctions were flagged up as 'Package' nodes in the UI. This PR attempts to add functions coming from Packages, regardless of their node type.

Changes (the gif is a bit long, sorry):

Limitations

In the example below, a node coming from the Forma package AssemblyName is not found in the list of packages insdie the NodePackageDictionary:

• assemblyName = {DynamoForma, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null}

Conclusion

For this function to work correctly, package authors must make sure that the nodes are contained within the same assembly that the package will be listed under by the PackageExtension (please, correct me if I am wrong on this one).

Declarations

Check these if you believe they are true

• The codebase is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated
• This PR contains no files larger than 50 MB

Release Notes

• added PackageName check to mark a node as a CustomNode
• removed limitation on how the PackageName is generated, which would only limit that to nodes with IsCustomFuction set to true

Reviewers

@QilongTang
@zeusongit
@reddyashish

FYIs

@Amoursol