Skip to content

[DYN-7466] Navigate-to-corresponding-node/group-by-clicking-it-in-the-TuneUp-list#15504

Merged
reddyashish merged 1 commit intoDynamoDS:masterfrom
ivaylo-matov:DYN-7466-Navigate-to-corresponding-node/group-by-clicking-it-in-the-TuneUp-list
Sep 30, 2024
Merged

[DYN-7466] Navigate-to-corresponding-node/group-by-clicking-it-in-the-TuneUp-list#15504
reddyashish merged 1 commit intoDynamoDS:masterfrom
ivaylo-matov:DYN-7466-Navigate-to-corresponding-node/group-by-clicking-it-in-the-TuneUp-list

Conversation

@ivaylo-matov
Copy link
Contributor

@ivaylo-matov ivaylo-matov commented Sep 24, 2024

Purpose

PR aims to address https://jira.autodesk.com/browse/DYN-7466 .

Changes to DynamoViewModel.ShowElement and WorkspaceViewModel.FindById now enable group nodes in TuneUp to be selected and centered in the current workspace, similar to node elements.

Goes along with DynamoDS/TuneUp#61

DYN-7466_Fix

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Changes in DynamoViewModel.ShowElement & WorkspaceViewModel.FindById allow group nodes in TuneUp to be selected and centered in the current workspace, similarly to nodes.

Reviewers

@QilongTang
@reddyashish

FYIs

@Amoursol
@dnenov

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang added this to the 3.4 milestone Sep 24, 2024
@reddyashish reddyashish merged commit e9993f0 into DynamoDS:master Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants