[DYN-7332] Add and remove pins to groups#15489
Merged
reddyashish merged 10 commits intoDynamoDS:masterfrom Oct 8, 2024
Merged
Conversation
+ unit test
`AddConnectorPinsToGroups` was failing because the original version on `Nodes` was excluding pins from selection, but adding pins related to nodes.
with added option in the context menu to remove pins from a group or with Alt + Left Mouse click. + another unit test
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7332
UI Smoke TestsTest: success. 11 passed, 0 failed. |
reddyashish
approved these changes
Sep 25, 2024
Collaborator
|
@ivaylo-matov can you check these tests on this branch? |
ignore pins when comparing the graphs
Contributor
Author
@reddyashish, please let me know if this solution is acceptable. The serialization tests were failing due to a mismatch between the connectorPinModel GUIDs in the serialized graph and the in-memory .dyn graph. This caused the comparison of AnnotationMaps to fail. Excluding connectorPinModels resolves the issue and prevents the test failure |
reddyashish
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PR aims to address latest comments in DYN-7332
Changes:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
@QilongTang
@reddyashish
FYIs
@dnenov
@Amoursol