DYN-2763 Add options to change Python Engine in multiple python nodes#15475
DYN-2763 Add options to change Python Engine in multiple python nodes#15475QilongTang merged 13 commits intoDynamoDS:masterfrom
Conversation
|
In my opinion it would be ok to wait on dyf support |
zeusongit
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-2763
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with some comments
|
Thanks, waiting for PR checks to finish |
|
Added DYF support. |
| { | ||
| if (!Workspaces.OfType<CustomNodeWorkspaceModel>().Contains(customNodeWorkspace)) | ||
| { | ||
| AddWorkspace(customNodeWorkspace); |
There was a problem hiding this comment.
After the custom node workspace loaded silently, we should also remove it somehow after Python engine switched?
There was a problem hiding this comment.
I thought about that as well, but the workspaces should/are marked dirty IMO, so user will know which custom nodes were updated. One scenario where this would be bad is maybe if a user has too many custom nodes?
Also saving the custom nodes for them and then closing the workspace seemed a bit hacky, would you like that instead?
There was a problem hiding this comment.
I would prefer the current option then, maybe when customer has too many dyfs in the canvas, then this could potentially be a problem
There was a problem hiding this comment.
Yes, we could consult customers for feedback and then later update this functionality.
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
The silent loading seems safe to me, I can't think of any side effects for now other than maybe more memory used. LGTM with one question about workspace unloading
3 participants
Purpose
This PR adds 2 additional ways to update Python Engine of multiple python nodes
Can Handle DYF/Custom nodes
TODO:
Add support for DYF'sDeclarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/dynamo