[DYN-7332] Add pins to groups#15452
Conversation
+ unit test
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7332
UI Smoke TestsTest: success. 11 passed, 0 failed. |
|
@ivaylo-matov This test ConnectorPinsGetsAddedToTheGroup is failing. Can you check that? |
`AddConnectorPinsToGroups` was failing because the original version on `Nodes` was excluding pins from selection, but adding pins related to nodes.
|
@reddyashish , this commit should fix the issue. All tests from AnnotationViewModelTests & AnnotationViewTests pass now. |
|
Self serve job did not complete. Running it again https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16390/ |
|
This one test is failing: Dynamo.Tests.SchedulerIntegrationTests.TestTaskQueuePreProcessing01. |
3 participants
Purpose
PR aiming to address https://jira.autodesk.com/browse/DYN-7332 . Allows users to manually add connectorPins to groups.
Unit test included.
Hope that's okay 🤞
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Users can now manually add pin to group even if the related nodes are outside that group.
Reviewers
@dnenov
@reddyashish
FYIs
@Amoursol