DYN-7330 Add a button to show Sample Graph folder and Sample Dataset#15449
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7330
UI Smoke TestsTest: success. 11 passed, 0 failed. |
|
|
| if (Directory.Exists(datasetsPath)) | ||
| { | ||
| sampleDatasetsPath = datasetsPath; | ||
| } |
There was a problem hiding this comment.
So, we open a default page when dataset folder does not exist, or nothing happens?
There was a problem hiding this comment.
will falling back on root or desktop be sufficient? Any other suggestions?
"Open file location" sounds good to me. |
|
button text changes to "Open file location" in DynamoDS/DynamoHome#28 |
|
Hi @ivaylo-matov Please also bump up the package version referenced in csproj file so once the new package is published, this PR would be ready to go |
QilongTang
changed the title
|
@reddyashish I restarted most of the checks which were failing, they were failing because the npm package was not available when the checks running. The selfServe restarted at https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16403/ |
|
@reddyashish Self Serve passed on this one |
|
@ivaylo-matov Please cherry-pick this to RC3.3.0_master branch |
|
@ivaylo-matov @avidit I built latest master and the new controls did not work for me |
|
@QilongTang , looks like the changes have not gone to master. Should I create a new PR? |
hi @ivaylo-matov So this change was merged to master branch last week after RC3.3.0_master branch was cut, please make your new changes to master branch and team will decide if we want to cherry-pick both this PR and your new PR to RC branch for the upcoming 3.3.0 release |
|
Will do, thank you |
4 participants
Purpose
PR to address https://jira.autodesk.com/browse/DYN-7330.
Adds a button for a dropdown to allow users to find Sample Graph folder and Sample Dataset. The button replaces the current "Show samples in folder button"
Goes along with : DynamoDS/DynamoHome#28
Hope that's okay 🤞
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Adds a button for a dropdown to allow users to find Sample Graph folder and Sample Dataset. The button replaces the current "Show samples in folder button"
Reviewers
@dnenov
@reddyashish
FYIs
@Amoursol