Merged
Conversation
- new wizard-style custom user control
Contributor
|
Looks AWESOME @dnenov! |
Contributor
|
Indeed, looking good man @dnenov ! |
reddyashish
reviewed
Aug 21, 2024
| public static readonly DependencyProperty TitleProperty = | ||
| DependencyProperty.Register("Title", typeof(string), typeof(StepIndicatorControl), new PropertyMetadata("Step")); | ||
|
|
||
| public string Title |
Collaborator
There was a problem hiding this comment.
Add summary to public properties
Collaborator
Author
There was a problem hiding this comment.
Added summaries to all public properties!
reddyashish
approved these changes
Sep 5, 2024
Collaborator
reddyashish
approved these changes
Oct 14, 2024
Contributor
|
@reddyashish I think we are supposed to review and merge #15536 instead? |
15 tasks
Collaborator
|
So this is not needed? |
Collaborator
|
@QilongTang I can revert this once you confirm it. |
Contributor
|
@reddyashish Can you check locally? I think the wizard is not complete, this PR is a WIP. I would prefer we revert in that case |
reddyashish
added a commit
to reddyashish/Dynamo
that referenced
this pull request
Oct 15, 2024
This reverts commit f6c1bea.
9 tasks
zeusongit
pushed a commit
that referenced
this pull request
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A PR containing the preliminary UI work for the design rehaul of the Package Manager publishing package. "Step-by-step wizard. Users should be able to navigate around by clicking the numbers at the top (once each step has been successfully fulfilled)."
The control has not been implemented anywhere in code yet.
Link to the Figma board: https://www.figma.com/design/MJh76m7bbafE3sjwLUTZhZ/Dynamo-package-manager-update?node-id=2409-15319&t=4BQN0lZMCg2MRHTp-0
UI Changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang
@Amoursol
FYIs
@reddyashish