DYN-5709: publish version fix#15408
Merged
reddyashish merged 2 commits intoDynamoDS:masterfrom Jul 26, 2024
Merged
Conversation
- fixing the publish version workflow by removing the deletion of existing files from the 'retain folder structure' route - a few minor issues found, fix
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-5709
UI Smoke TestsTest: success. 11 passed, 0 failed. |
9 tasks
Collaborator
Author
|
There was a good investigation done regarding the use |
- solves the purpose of publish for the first time vs publish a version online
reddyashish
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Following up on a https://jira.autodesk.com/browse/DYN-5709, this PR addresses a bigger concern. The
Publish Versionexperience has been broken for a while now. After a lengthy research and trying several options, the proposed solution is very simple.Context - the retain folder structure option was introduced as an alternative way to publish a package. It was modeled after the
existingand only way, which lead Dynamo predefine a set of 4 folders (bin,doc,dyf,extra), and allocate packages accordingly. As one of the steps, this flow would check and delete pre-existing files in the above locations before copying the files to a finalize package structure. This made sense, as the files would come from a separate place to be copied in this new package folder structure.In contrast, the
retain folder structuretakes files and folders exactly as they are, and copies them to the default package folder, so the final package is loaded in Dynamo and ready to use. However, in case there is a folder already installed locally, and the user needs to submit it for the first time online, or submit it as a new version, the source files will be the same as the target files. In this case, it makes no sense to try to override the file with the same file, so we simply skip it.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@aparajit-pratap
@reddyashish
@QilongTang
@zeusongit
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of