DYN-7200 use hardcoded string for type name instead of typeof operator#15358
Merged
pinzart90 merged 1 commit intoDynamoDS:masterfrom Jul 1, 2024
Merged
DYN-7200 use hardcoded string for type name instead of typeof operator#15358pinzart90 merged 1 commit intoDynamoDS:masterfrom
pinzart90 merged 1 commit intoDynamoDS:masterfrom
Conversation
QilongTang
approved these changes
Jun 28, 2024
Contributor
|
Morpheus team will make the branch ready shortly. Next week, we will contact DynamoRevit team to see if they are willing to adopt this fix as well as #15355 in 3.2.2. Stay tuned and thank you for proposing the fix 🚀 |
twastvedt
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7200
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This fixes a potential issue where an older version of DynamoCore not containing the PanelSurface type is run with Player pointing to a new version of DynamoCore that contains that type. To avoid potential type load exceptions in this scenario, this PR avoids the use of
typeofoperator and uses a hardcoded string instead for the type.❕ This needs to be cherry-picked into 3.2.2.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of