DYN-7111 Enable package search to show results for package authors as the search key#15338
Merged
zeusongit merged 3 commits intoDynamoDS:masterfrom Jun 21, 2024
Merged
DYN-7111 Enable package search to show results for package authors as the search key#15338zeusongit merged 3 commits intoDynamoDS:masterfrom
zeusongit merged 3 commits intoDynamoDS:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7111
Contributor
Author
|
Unrelated test failures |
QilongTang
reviewed
Jun 21, 2024
QilongTang
reviewed
Jun 21, 2024
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
LGTM, one question mainly about the function override
Contributor
Author
QilongTang
approved these changes
Jun 21, 2024
Contributor
|
Any documentation we need to update after this PR? Internal wiki about Lucene? |
Contributor
Author
I was wondering if we have that, since there are a lot of conditions and customizations, I don't think we have any, but maybe @RobertGlobant20 knows? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The PR adds package authors to indexed data, this will enable users to search for packages based on the username of the desired author.
Before - After screenshots for search comparison:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/dynamo
FYIs
@Amoursol