DYN-7033: Home Open button should remember last opened location#15323
Merged
reddyashish merged 2 commits intoDynamoDS:masterfrom Jun 18, 2024
Merged
DYN-7033: Home Open button should remember last opened location#15323reddyashish merged 2 commits intoDynamoDS:masterfrom
reddyashish merged 2 commits intoDynamoDS:masterfrom
Conversation
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7033
Contributor
|
Nice |
Collaborator
Author
|
@QilongTang unit test is getting tricky to add for this particular case. Probably a UI test would suit better. Would like to get this change in without a test now. |
QilongTang
approved these changes
Jun 18, 2024
UI Smoke TestsTest: success. 2 passed, 0 failed. |
Contributor
|
Hi @reddyashish Would you ship it and cherry-pick? I think although this is a small improvement, it would be bothering without it for the release. Also, would you add a gif? |
Collaborator
Author
|
yeah added a gif, cherrypick to 3.2.1? |
Contributor
Yes, please |
9 tasks
dnenov
pushed a commit
to dnenov/Dynamo
that referenced
this pull request
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Task: https://jira.autodesk.com/browse/DYN-7033
Open on homepage will now point to the last opened workspace location instead of the samples directory. It will point to the samples directory until a workspace is opened for a particular location.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Home Open button should remember last opened location
Reviewers
@QilongTang