DYN-6808-NodeIcons-P4-P5-P6 Automatic Process#15283
DYN-6808-NodeIcons-P4-P5-P6 Automatic Process#15283QilongTang merged 2 commits intoDynamoDS:masterfrom
Conversation
I done a fix due that when the resx file contains entries referencing a png image, the tool was not replacing attributes so the Dynamo solution was not compiling. I've used the Update Node Icon tool for the folders P4, P5 and P6 folders using the 400 dpi folder.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6808
|
This is a screenshot of a small subset of icons automatically updated by the tool. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
| if (currentElementValue.ToLower().Contains(".png") || currentElementValue.ToLower().Contains(".jpg")) | ||
| { | ||
| //If the resx file is referencing a png image then we need to update/add the type and mimetype attributes | ||
| XAttribute attRemove = oldElement.Attribute("type"); |
There was a problem hiding this comment.
@zeusongit I thought you mentioned there is no resx file referencing a legacy png, maybe I got it wrong?
There was a problem hiding this comment.
@QilongTang I've found 4 entries in DSCoreNodesImages.resx that are referencing the png image directly (without using base64).
There was a problem hiding this comment.
@QilongTang I was wrong, there were 2 icons which were still using the png, we discussed this in slack, roberto will remove these icons after updating them to b64.
There was a problem hiding this comment.
Just commited a change for removing the png files
6c591c4
There was a problem hiding this comment.
Thanks, then the logic here is more for future proofing when things goes wrong from my understanding.
Removing not used png images
3 participants
Purpose
Updating several icons using the Update Node Icon tool
I done a fix due that when the resx file contains entries referencing a png image, the tool was not replacing attributes so the Dynamo solution was not compiling.
I've used the Update Node Icon tool for the folders P4, P5 and P6 folders using the 400 dpi folder.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Updating several icons using the Update Node Icon tool
Reviewers
@QilongTang
FYIs
@zeusongit