DYN-6840: add new boundary condition node by pinzart90 · Pull Request #15270 · DynamoDS/Dynamo

pinzart90 · 2024-05-30T17:03:48Z

Purpose

https://jira.autodesk.com/browse/DYN-6840

Add new boundary condition node for panel surfaces

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB

Release Notes

Add new boundary condition dropdown node for panel surfaces.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

src/Libraries/CoreNodes/ProtoGeometryHelper.cs

src/Libraries/GeometryUIWpf/PanelSurfaceBoundaryConditions.cs

pinzart90 · 2024-05-30T17:06:42Z

Still have to add resources (although I am not sure if we want more localization for 3.2)

github-actions

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6840

pinzart90 · 2024-05-30T17:13:46Z

github-actions · 2024-05-30T17:19:18Z

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

aparajit-pratap · 2024-05-30T17:29:30Z

src/Libraries/GeometryUIWpf/PanelSurfaceBoundaryConditions.cs

+namespace GeometryUIWpf
+{
+    [IsVisibleInDynamoLibrary(true)]
+    [NodeName("PanelSurfaceBoundaryConditions")]


Can we just make this singular like the enum itself - PanelSurfaceBoundaryCondition?

PanelSurfaceBoundaryCondition will collide with the ENum coming from ProtoGeom (at least in the library view)

@aparajit-pratap is the layout spec good enough for now ?

Can you move the other PanelSurfaceBoundaryCondition node under this new BoundaryConditioncategory as well? I think more than one node can have the same name.

or maybe there's a special setting to allow same name nodes under the same parent ?

Or I can change the name of the new node (again)

Maybe only the same named nodes are allowed if and only if they have different inputs?

@Amoursol what do you think about the layout above ? 2 entries with the same name "PanelSurfaceBoundaryCOndition"
ONe is a dropdown node, the other is category (I think) for individual boundaryCOndition nodes

@pinzart90 As it's still experimental, I don't think layoutspec changes matter too much. So we can do any of those changes and evaluate later if need be.

On the name front, could we please name it "Select Boundary Condition"? This is similar to some Revit paradigms. Do we also need to mark it an Action, not a Query?

Probably not plural - unlike image. Sorry on that miss!

mjkkirschner · 2024-05-31T21:57:01Z

src/Libraries/GeometryUI/PanelSurfaceBoundaryConditions.cs

+    [OutPortTypes(nameof(PanelSurfaceBoundaryCondition))]
+    [OutPortDescriptions("PanelSurface BoundaryCondition enum value")]
+    [IsDesignScriptCompatible]
+    public class PanelSurfaceBoundaryConditionDropDown : DSDropDownBase


I think there is an enum based dropdown...
https://github.com/DynamoDS/DynamoRevit/blob/bcb122017c2e5ebe63e4198f8b8f84a3abc5305a/src/Libraries/RevitNodesUI/GenericClasses.cs#L128

maybe it makes sense to move that class here?

There is also an EnumBase class inside Dynamo, but it generates the string values not the actual enum types.

Dynamo/src/Libraries/CoreNodeModels/Enum.cs

Line 39 in 0b23a2e

public abstract class EnumBase<T> : DSDropDownBase

I guess they could all be made into a more generic class. I would consolidate them in another task

src/Libraries/GeometryUI/PanelSurfaceBoundaryConditions.cs

aparajit-pratap · 2024-06-03T16:38:53Z

src/Libraries/GeometryUI/PanelSurfaceBoundaryConditions.cs

+        /// </summary>
+        public override IEnumerable<AssociativeNode> BuildOutputAst(List<AssociativeNode> inputAstNodes)
+        {
+            //Some of the legacy categories which were not working before will now be out of index.


What does this comment mean?

nothing, I can remove it

aparajit-pratap · 2024-06-03T16:40:44Z

test/Tools/NodeDocumentationMarkdownGeneratorTests/MarkdownGeneratorCommandTests.cs


            var generatedFileNames = tempDirectory.GetFiles().Select(x => x.Name);
-            Assert.AreEqual(707, generatedFileNames.Count());
+            Assert.AreEqual(705, generatedFileNames.Count());


I just changed this to 709??

I'll pull your changes and update this

…oDS/Dynamo into add_boundarycond_enum_node

update

8322d70

pinzart90 commented May 30, 2024

View reviewed changes

src/Libraries/CoreNodes/ProtoGeometryHelper.cs Show resolved Hide resolved

pinzart90 commented May 30, 2024

View reviewed changes

src/Libraries/GeometryUIWpf/PanelSurfaceBoundaryConditions.cs Show resolved Hide resolved

pinzart90 commented May 30, 2024

View reviewed changes

src/Libraries/GeometryUIWpf/PanelSurfaceBoundaryConditions.cs Outdated Show resolved Hide resolved

Update PanelSurfaceBoundaryConditions.cs

86eb823

github-actions bot changed the title ~~add new boundary condition node~~ DYN-6840: add new boundary condition node May 30, 2024

github-actions bot reviewed May 30, 2024

View reviewed changes

pinzart90 requested a review from aparajit-pratap May 30, 2024 17:11

aparajit-pratap reviewed May 30, 2024

View reviewed changes

pinzart90 added 3 commits May 30, 2024 23:33

update resources

18c603c

update

830c1df

update

144813b

pinzart90 marked this pull request as ready for review May 31, 2024 14:57

pinzart90 requested a review from mjkkirschner May 31, 2024 14:57

pinzart90 added 4 commits May 31, 2024 11:31

Update GeometryUIWpf.PanelSurfaceBoundaryConditionDropDown_img.jpg

e917df1

Update GeometryUIWpf.PanelSurfaceBoundaryConditionDropDown.dyn

1df7c03

Update ProtoGeometryImages.resx

a728944

Update MarkdownGeneratorCommandTests.cs

b485390

mjkkirschner reviewed May 31, 2024

View reviewed changes

pinzart90 requested review from aparajit-pratap and mjkkirschner June 3, 2024 13:55

aparajit-pratap reviewed Jun 3, 2024

View reviewed changes

src/Libraries/GeometryUI/PanelSurfaceBoundaryConditions.cs Outdated Show resolved Hide resolved

aparajit-pratap reviewed Jun 3, 2024

View reviewed changes

src/Libraries/GeometryUI/PanelSurfaceBoundaryConditions.cs Show resolved Hide resolved

aparajit-pratap reviewed Jun 3, 2024

View reviewed changes

pinzart90 and others added 2 commits June 3, 2024 12:44

Merge branch 'master' into add_boundarycond_enum_node

a4ba1f5

Update PanelSurfaceBoundaryConditions.cs

8689c68

pinzart90 added 3 commits June 3, 2024 12:45

Merge branch 'master' into add_boundarycond_enum_node

b3bca71

update

154ca1c

Merge branch 'add_boundarycond_enum_node' of https://github.com/Dynam…

a010721

…oDS/Dynamo into add_boundarycond_enum_node

aparajit-pratap approved these changes Jun 3, 2024

View reviewed changes

Update PanelSurfaceBoundaryConditions.cs

25ce1e0

mjkkirschner approved these changes Jun 3, 2024

View reviewed changes

pinzart90 added 2 commits June 3, 2024 14:10

review comments

bb788b1

Update GeometryUIWpf.PanelSurfaceBoundaryConditionDropDown.dyn

54e9220

pinzart90 merged commit de384e7 into master Jun 3, 2024

pinzart90 deleted the add_boundarycond_enum_node branch June 3, 2024 20:54

pinzart90 added a commit that referenced this pull request Jun 4, 2024

cherry-pick DYN-6840: add new boundary condition node (#15270)

45e30f5

QilongTang pushed a commit that referenced this pull request Jun 4, 2024

cherry-pick DYN-6840: add new boundary condition node (#15270) (#15276)

7edf508

Conversation

pinzart90 commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Declarations

Release Notes

Reviewers

FYIs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pinzart90 commented May 30, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

pinzart90 commented May 30, 2024

Uh oh!

github-actions bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

UI Smoke Tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Amoursol Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjkkirschner May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pinzart90 commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

Amoursol Jun 3, 2024 •

edited

Loading

mjkkirschner May 31, 2024 •

edited

Loading