DYN-7033: distinct recent files#15260
Merged
reddyashish merged 2 commits intoDynamoDS:masterfrom May 29, 2024
Merged
Conversation
- now explicitly filters out duplicate recent graphs based on location (cannot add the same graph twice to the list of recent graphs) - note: still possible to have the same graph saved in multiple locations
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7033
avidit
approved these changes
May 29, 2024
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
approved these changes
May 29, 2024
Collaborator
|
The self-serve timed out. Running it again to verify the issue. |
Collaborator
|
Will cherrypick this once testing is done. |
reddyashish
pushed a commit
to reddyashish/Dynamo
that referenced
this pull request
May 29, 2024
(cherry picked from commit 71b18b0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
References https://jira.autodesk.com/browse/DYN-7033
Same graphs opened twice appear twice on AppHome.Note: it is still possible to show the same graph name saved in multiple file locations. For details, user can utilize the
Listview in the HomePage.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@avidit
@reddyashish
FYIs
@Amoursol