DYN-6997 Fix crash when view is null for nodes#15259
Merged
QilongTang merged 1 commit intoDynamoDS:masterfrom May 29, 2024
Merged
DYN-6997 Fix crash when view is null for nodes#15259QilongTang merged 1 commit intoDynamoDS:masterfrom
QilongTang merged 1 commit intoDynamoDS:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6997
UI Smoke TestsTest: success. 2 passed, 0 failed. |
reddyashish
approved these changes
May 29, 2024
QilongTang
approved these changes
May 29, 2024
Collaborator
|
@zeusongit Do we need this for 3.2? |
Contributor
|
This is currently scheduled on 3.3 release, fine to not cherry-pick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-6997
Crash StackTrace:
Don't know under what setup the user triggered the click action that they got a null view, but the PR now handles a nullable view variable. I can log this to console in a try-catch as well, if preferred.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/dynamo