Skip to content

[Cherry pick] #15247 More localization on Dynamo Home#15258

Merged
QilongTang merged 1 commit intoRC3.2.0_masterfrom
CherryPick
May 28, 2024
Merged

[Cherry pick] #15247 More localization on Dynamo Home#15258
QilongTang merged 1 commit intoRC3.2.0_masterfrom
CherryPick

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented May 28, 2024

Purpose

Follow up of #15247, cherry-picking to RC3.2 branch

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 3.2 milestone May 28, 2024
@github-actions
Copy link

github-actions bot commented May 28, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

reddyashish
reddyashish reviewed May 28, 2024
View reviewed changes
src/DocumentationBrowserViewExtension/DocumentationBrowserViewExtension.cs
.First(x => x.AnnotationModel == annotation);

var styleItem = annotationViewModel.GroupStyleList.First(x => x.Name.Equals(DynamoProperties.Resources.GroupStyleDefaultReview));
GroupStyleItem styleItem = null;
Copy link
Collaborator

@reddyashish reddyashish May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is already merged into master, right?

Copy link
Contributor Author

@QilongTang QilongTang May 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reddyashish updated base branch

@QilongTang QilongTang changed the base branch from master to RC3.2.0_master May 28, 2024 18:06
@QilongTang QilongTang merged commit 6966d47 into RC3.2.0_master May 28, 2024
@QilongTang QilongTang deleted the CherryPick branch May 28, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avidit avidit avidit approved these changes

@reddyashish reddyashish reddyashish approved these changes

@zeusongit zeusongit Awaiting requested review from zeusongit

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.2

Development

Successfully merging this pull request may close these issues.

3 participants

@QilongTang @avidit @reddyashish