DYN-6927: Improvements to RemovePIIData API #15236
DYN-6927: Improvements to RemovePIIData API #15236reddyashish merged 5 commits intoDynamoDS:masterfrom
Conversation
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6927
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
One comment then LGTM
| //result = Regex.Replace(result, ipPattern, ""); | ||
| result = Regex.Replace(result, ipPattern, ""); | ||
| result = Regex.Replace(result, creditCardPattern, ""); | ||
| result = Regex.Replace(result, websitePattern, ""); |
There was a problem hiding this comment.
hi @reddyashish So the trick is to just change the order of regex?
There was a problem hiding this comment.
The main change is to use RemovePIIData(JObject jsonObject) API on the whole json object which will look for the regex pattern in the Views, Annotations etc.
There was a problem hiding this comment.
Right, in the past we are running the regex against the text?
2 participants
Purpose
Task: https://jira.autodesk.com/browse/DYN-6927
Using the RemovePIIData(JObject jsonObject), we check for the regex patterns in specific parts like the VIew or Annotations section of the JSON to remove the personal sensitive data.
It should remove email pattern, SSN number pattern, credit card pattern, user directory pattern, IP address pattern, date patterns and website patterns.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
DYN-6927: Improvements to RemovePIIData API to accurately remove only the sensitive personal info.
Reviewers
@QilongTang @zeusongit
FYIs
@DynamoDS/dynamo