DYN-6633: Define Data node revisions#15229
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6633
UI Smoke TestsTest: success. 2 passed, 0 failed. |
Contributor
|
LGTM |
saintentropy
approved these changes
May 23, 2024
dnenov
reviewed
May 23, 2024
Collaborator
dnenov
left a comment
dnenov
left a comment
There was a problem hiding this comment.
Amazing, a lot of simplifications to the code! Quite a few new ways of doing things. Everything looks good, only one idea - do you think we could rename 'IsAutoMode' to something better suited with the new 'Auto-detect' paradigm?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
IsSupportedDataNodeTypetoEvaluateDefineDataNodefor clarity.EvaluateDefineDataNodeas Obsolete to indicate it may change (needs to be public for AST)DefineDataNodeViewCustomizationandDataNodeDynamoTypeinternal.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of