DYN-6693 Alert user for duplicate files when publishing package#15225
Merged
zeusongit merged 5 commits intoDynamoDS:masterfrom May 20, 2024
Merged
DYN-6693 Alert user for duplicate files when publishing package#15225zeusongit merged 5 commits intoDynamoDS:masterfrom
zeusongit merged 5 commits intoDynamoDS:masterfrom
Conversation
zeusongit
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6693
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
reviewed
May 17, 2024
src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
approved these changes
May 19, 2024
Enzo707
pushed a commit
to Enzo707/Dynamo
that referenced
this pull request
May 22, 2024
…moDS#15225) Co-authored-by: Aaron (Qilong) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When files with same name exist in the package being uploaded by the publisher, only one of those duplicate files is retained, as they get merged into the same directory when retain folder structure toggle is off.
After this change the user will be alerted this when it occurs.
The alert message text is being finalized by the UX, and will be updated as a resource string soon.Strings added to resource string
Introduced a new dialog box with scrollable body for longer list of duplicate files.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/dynamo