DYN-6967 Crash when placing List selector archi-lab Dynamo nodes in canvas#15224
Merged
QilongTang merged 5 commits intomasterfrom May 17, 2024
Merged
DYN-6967 Crash when placing List selector archi-lab Dynamo nodes in canvas#15224QilongTang merged 5 commits intomasterfrom
QilongTang merged 5 commits intomasterfrom
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6967
QilongTang
commented
May 16, 2024
src/DynamoCoreWpf/ViewModels/Search/NodeSearchElementViewModel.cs
Outdated
Show resolved
Hide resolved
UI Smoke TestsTest: success. 2 passed, 0 failed. |
pinzart90
reviewed
May 17, 2024
src/DynamoCoreWpf/ViewModels/Search/NodeSearchElementViewModel.cs
Outdated
Show resolved
Hide resolved
reddyashish
approved these changes
May 17, 2024
Contributor
Author
|
https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16037/ passed while the later job was terminated |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
per DYN-6967 Crash when placing List selector archi-lab Dynamo nodes in canvas. This could happen when nodes from 3rd party in package crash at node constructor.
Example crash stacktrace
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fix a crash when placing List selector archi-lab Dynamo nodes in canvas, Dynamo would crash and show crash report dialog. This crash currently can only be fixed by package author.
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of