DYN-6857 homepage settings refactor#15223
Merged
QilongTang merged 1 commit intoDynamoDS:masterfrom May 17, 2024
Merged
Conversation
- no longer serializes to Dictionary, but list<string> of ':' delimited key/value pairs
UI Smoke TestsTest: success. 2 passed, 0 failed. |
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6857
reddyashish
approved these changes
May 16, 2024
QilongTang
approved these changes
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Simplification of the way HomePage settings were serialized as part of the Dynamo Preferences. No longer maintains a
Dictionary<string, object>but usesList<string>instead.Formerly, a workaround was created to serialize a json-serialized version of the Dictionary, as the limitation is that xaml cannot serialize Dictionary types.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang
@reddyashish
FYIs