UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

hi @tinrobot2000 Thanks a lot for proposing this PR, my team will review and make a decision soon on this. Good work on addressing wishlist issue!

@aparajit-pratap @mjkkirschner Do you think this is as per design to not gte the negative index from the list items?

@aparajit-pratap @mjkkirschner Do you think this is as per design to not gte the negative index from the list items?

If you checkout the builtin implementation of Get indexing it does support negative indices:

I think this would be an okay change but it requires the following changes IMO.

1. a test
2. consider performance impact, 1 if statement probably is not too bad.
3. I don't see any reason to raise the IndexOutOfRangeException, the indexing operation is going to do that anyway, what am I missing?

@aparajit-pratap @mjkkirschner Do you think this is as per design to not gte the negative index from the list items?

If you checkout the builtin implementation of Get indexing it does support negative indices:

Dynamo/src/Libraries/DesignScriptBuiltin/Builtin.cs

Line 33 in 49a3f7c

public static object ValueAtIndex(IList list, int index)

I think this would be an okay change but it requires the following changes IMO.

1. a test
2. consider performance impact, 1 if statement probably is not too bad.
3. I don't see any reason to raise the IndexOutOfRangeException, the indexing operation is going to do that anyway, what am I missing?

Hi @mjkkirschner I think when index is too large or too negative to handle, it could be out of range so exception is only needed in that case. I am adding unit tests for those cases as well.

Hi @mjkkirschner I think when index is too large or too negative to handle, it could be out of range so exception is only needed in that case. I am adding unit tests for those cases as well.

yeah I'm still not getting it - when you do

var x= int[1]
var y = x[10000000]

that will throw an out of range exception, you don't have to detect it yourself first...