DYN-6874 Logging Packages Tour#15203
Merged
QilongTang merged 1 commit intoDynamoDS:masterfrom May 13, 2024
Merged
Conversation
Due that the Packages guide doesn't have a Welcome popup (like the other guides) the Guide.Sequence starts at 1 (instead of 0) so I had to do a fix for calculating the number of steps correctly and modify the validation which is logging information when packages tour is completed.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6874
Contributor
Author
|
This is a GIF showing that when the Package tour is completed we will be logging the Completed status. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
reddyashish
approved these changes
May 10, 2024
zeusongit
reviewed
May 10, 2024
QilongTang
reviewed
May 13, 2024
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with remaining comment to be addressed
QilongTang
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing Packages guide logging when is completed by user.
Due that the Packages guide doesn't have a Welcome popup (like the other guides) the Guide.Sequence starts at 1 (instead of 0) also the sequences are repeated (this allow to have conditional guide flow) so I had to do a fix for calculating the number of steps correctly and modify the validation which is logging information when packages tour is completed.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing Packages guide logging when is completed by user.
Reviewers
@QilongTang
@zeusongit
FYIs